Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.13.0 #420

Merged
merged 6 commits into from
Aug 16, 2024
Merged

Release 4.13.0 #420

merged 6 commits into from
Aug 16, 2024

Conversation

longshuicy
Copy link
Member

I made a minor update to the develop branch. Specifically, I revised the text portion of the markdown link from https://incore.ncsa.illinois.edu/auth/realms/In-core/protocol/openid-connect/registrations to "registration link."

If the link is used without the necessary query parameters, such as client_id and scope, it will not function correctly.

My concern was that someone might copy and paste the incomplete link, which would fail to direct them to the registration page. Hence the update.

longshuicy and others added 5 commits June 11, 2024 14:14
* fix wrong output key in the screenshot

* wrong link in the changelog
* add pyincore-data instruction

* fix wrong text

* update changelog; add hyperlinks

---------

Co-authored-by: YONG WOOK KIM <[email protected]>
…ak (#419)

* Fixes #416 - Updated account instructions for registering with keycloak

* Updated registration image

* Update registration URL
@longshuicy longshuicy requested review from navarroc and a team August 16, 2024 02:50
CHANGELOG.md Outdated Show resolved Hide resolved
@navarroc navarroc requested review from ywkim312 and ylyangtw August 16, 2024 14:49
@longshuicy longshuicy requested a review from navarroc August 16, 2024 14:52
Copy link
Member

@navarroc navarroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested build and ran locally.

@longshuicy longshuicy merged commit cd283f4 into main Aug 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants