-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #416 - Updated account instructions for registering with keycloak #419
Fixes #416 - Updated account instructions for registering with keycloak #419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Could you resolve the merge conflict whenever you have time?
…or-registering-with-keycloak
I have fixed the problem @longshuicy found; however, to test it, you will need make one small change and build the docs locally. The link is very specific to the instance running keycloak and right now prod doesn't allow registration yet so the links will tell you registration isn't allowed. If you want to test it locally, you can open account.md and replace incore.ncsa.illinois.edu with incore-dev.ncsa.illinois.edu. The link should take you to the registration page on dev. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have deployed this PR to dev and tested in there and looked good. Approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on dev. Looks good.
The account registration instructions and FAQ are updated. Once we decide if we are enabling reCAPTCHA, I will need to update the image file.