Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #416 - Updated account instructions for registering with keycloak #419

Conversation

navarroc
Copy link
Member

@navarroc navarroc commented Aug 9, 2024

The account registration instructions and FAQ are updated. Once we decide if we are enabling reCAPTCHA, I will need to update the image file.

@navarroc navarroc linked an issue Aug 9, 2024 that may be closed by this pull request
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you resolve the merge conflict whenever you have time?

manual_jb/content/account.md Outdated Show resolved Hide resolved
manual_jb/content/faq.md Outdated Show resolved Hide resolved
@navarroc navarroc requested a review from longshuicy August 15, 2024 13:30
@navarroc
Copy link
Member Author

I have fixed the problem @longshuicy found; however, to test it, you will need make one small change and build the docs locally. The link is very specific to the instance running keycloak and right now prod doesn't allow registration yet so the links will tell you registration isn't allowed. If you want to test it locally, you can open account.md and replace incore.ncsa.illinois.edu with incore-dev.ncsa.illinois.edu. The link should take you to the registration page on dev.

Copy link
Member

@ywkim312 ywkim312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have deployed this PR to dev and tested in there and looked good. Approve

Copy link
Contributor

@ylyangtw ylyangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on dev. Looks good.

@ywkim312 ywkim312 merged commit 0e70fda into develop Aug 15, 2024
1 check passed
@ywkim312 ywkim312 deleted the 416-update-in-core-account-instructions-for-registering-with-keycloak branch August 15, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update IN-CORE Account instructions for registering with keycloak
4 participants