Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #401 - added buyout decision analysis documentation #403

Conversation

navarroc
Copy link
Member

@navarroc navarroc commented Jun 5, 2024

  • added buyout decision documentation
  • added buyout decision example notebook

@navarroc
Copy link
Member Author

navarroc commented Jun 5, 2024

Example notebook is being completed. Please review the documentation to make sure it all looks right. Thanks!

@navarroc
Copy link
Member Author

navarroc commented Jun 7, 2024

Everything is ready for review now

Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebook requires seaborn but never uses it

import seaborn as sns

Everything else looks good.

@navarroc
Copy link
Member Author

navarroc commented Jun 7, 2024

The notebook requires seaborn but never uses it

import seaborn as sns

Everything else looks good.

I'll remove it.

@navarroc
Copy link
Member Author

navarroc commented Jun 7, 2024

I removed the unused import and validated the notebook runs without issue.

@longshuicy longshuicy merged commit eb99470 into develop Jun 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add buyout model analysis documentation and example notebook
2 participants