Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add google analytics #397

Merged
merged 1 commit into from
May 30, 2024
Merged

add google analytics #397

merged 1 commit into from
May 30, 2024

Conversation

longshuicy
Copy link
Member

I build the image and can see the 200 status when pulling the configs

image

@longshuicy longshuicy linked an issue May 28, 2024 that may be closed by this pull request
Add google analytics to Sphinx doc #396
Closed
@navarroc
Copy link
Member

Jupyter book looks to support GA, not sure if that's useful here or not:

https://jupyterbook.org/en/stable/advanced/html.html

navarroc
navarroc approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@navarroc navarroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good.

@longshuicy longshuicy merged commit 0453009 into develop May 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywkim312 ywkim312 ywkim312 approved these changes

@navarroc navarroc navarroc approved these changes

@robkooper robkooper Awaiting requested review from robkooper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add google analytics to Sphinx doc
3 participants
@longshuicy @navarroc @ywkim312