Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #387 - added gas facility damage analysis documentation and example notebook #388

Merged
merged 3 commits into from
May 29, 2024
Merged

Fixes #387 - added gas facility damage analysis documentation and example notebook #388

merged 3 commits into from
May 29, 2024

Conversation

navarroc
Copy link
Member

  • Added gas facility damage analysis documentation page
  • Added example notebook

@navarroc navarroc linked an issue May 16, 2024 that may be closed by this pull request
Add gas facility damage example notebook and documentation #387
Closed
@navarroc navarroc requested a review from longshuicy May 16, 2024 19:44
@navarroc
Copy link
Member Author

This needs to be tested with IN-CORE/pyincore#574

@navarroc navarroc mentioned this pull request May 20, 2024
Merged
4 tasks
longshuicy
longshuicy approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Notebook runs well.

ywkim312
ywkim312 reviewed May 29, 2024
View reviewed changes
Copy link
Member

@ywkim312 ywkim312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking, it doesn't need to update _toc, right?

@navarroc
Copy link
Member Author

Just asking, it doesn't need to update _toc, right?

You are correct, let me fix that!

@navarroc
Copy link
Member Author

Just asking, it doesn't need to update _toc, right?

You are correct, let me fix that!

fixed!

@longshuicy longshuicy merged commit 720c30d into develop May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longshuicy longshuicy longshuicy approved these changes

@ywkim312 ywkim312 ywkim312 approved these changes

@Rashmil-1999 Rashmil-1999 Awaiting requested review from Rashmil-1999

@ylyangtw ylyangtw Awaiting requested review from ylyangtw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add gas facility damage example notebook and documentation
3 participants
@navarroc @ywkim312 @longshuicy