Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to reflect nonstructural building damage change #386

Conversation

longshuicy
Copy link
Member

@longshuicy longshuicy commented May 13, 2024

Related to pyincore PR: IN-CORE/pyincore#571

@longshuicy longshuicy requested a review from navarroc May 28, 2024 14:32
@navarroc
Copy link
Member

navarroc commented May 28, 2024

Should we change the name in the markdown as well to match the analysis name change and should we also update the analysis list? We could probably leave the markdown file names alone, but we would update analyses.md to be Building Nonstructural Damage instead of Nonstructural building damage?

In the markdown, there is a analysis title and currently it's nonstructural building damage (at the top of the file)

Copy link
Member

@ywkim312 ywkim312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR, non_stuctural_building_dmg.md has been removed and building_nostructural_dmg.md is added. However, the notebook name is still non_structural_building_dmg. This is correct, right?

@longshuicy
Copy link
Member Author

In this PR, non_stuctural_building_dmg.md has been removed and building_nostructural_dmg.md is added. However, the notebook name is still non_structural_building_dmg. This is correct, right?

I further change the jupyter notebook name. Upon approval I can resolve merge confict.

@longshuicy longshuicy requested a review from ywkim312 May 29, 2024 20:11
@longshuicy longshuicy merged commit 9ac88d5 into develop May 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update building nonstructural damage to support flood
3 participants