-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
creating a timeout ( issue #44) #47
base: main
Are you sure you want to change the base?
Conversation
@anshkarwasra Please follow pull request format on mergefest-hacker contributions.md file. Also please create a new branch for your change as per contribution guidelines |
okay |
There are a few issues that I think you need to address:
|
i will remove those clutter files but program is terminating as expected (yeah that empty input prompt still exist dk why) |
The empty input prompt should not be displayed , please work on that. Also consider squashing your commits into 1 commit as this is an easy issue and it is a good practice to squash multiple commits into one when dealing with good first issues. |
now its terminating without the empty input prompt |
kindly pull the updated codebase first and then register your changes to avoid conflicts |
i tried pulling from updated branch but its not resolving the conflict :( |
@anshkarwasra there are a lot of unneccesary line spaces in the new code , as well as modification of older code that is not required please fix that and resolve merge conflicts |
the keyboard interrupt error is still coming i think, can you crosscheck that, attach a video if need be :) |
Related Issue
**Closes #44 **
Type of Change
Description of Change
updating main.py with asyncio and sys module helping in tackling issue #44 adds an timeout of 10s whenever user is idle for more then 10s application terminates automatically
Implementation Details
instead of taking input from user normally, called input function separately in an async thread and used wait_for function to await for that thread . then to keep track if user is idle or not , i raised an timeout exception when ever it took more then 10s to execute the input thread and terminated the application