-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passage à vite #621
Merged
Merged
Passage à vite #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonai
reviewed
Jan 21, 2025
…de copie statique
ocruze
force-pushed
the
feat/use-symfony-vite-bundle
branch
from
January 30, 2025 16:27
3825e66
to
d368af6
Compare
tonai
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://symfony-vite.pentatrion.com/
J'ai dû faire une copie "one-shot" des actualités et des favicons dans le dossier public. Les favicons ne changeront pas fréquemment donc pas besoin de gérer les avec vite. Et les actualités ne bougent pas souvent non plus, sachant qu'elles vont disparaître de ce dépôt.
J'avais tenté d'inclure tout ça dans le build avec
import.meta.glob
, ça marche en dev mais pas en build, du coup j'ai laissé tomber.Du coup,
Sur linux avec docker :
Sur windows avec xampp :
Sur mut-dev :
Ça a l'air de bien fonctionner ✅
Légers changements d'installation :
Doc mise à jour : https://github.com/IGNF/cartes.gouv.fr/blob/feat/use-symfony-vite-bundle/docs/developer/install.md