Print an error message if the packaging properties file doesn't exist #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dorian Zimmer <[email protected]>
M-DLB
reviewed
Dec 3, 2024
There was a problem hiding this comment.
Hi @DorianZimmer-LM - Thanks for your contribution. I agree with the change.
Please, be aware that there is a conflict in your PR, since we moved the retrieveBuildResultProperty procedure definition to a different place in the script. I guess you just want to remove it from your file, and the PR should be fine.
Thank you!
| @@ -746,6 +746,9 @@ def parseInput(String[] cliArgs){ | |||
| if (propertiesFile.exists()) { | |||
| props.packagingPropertiesFile = opts.properties | |||
| propertiesFile.withInputStream { props.load(it) } | |||
| } else { | |||
| println "*! [ERROR] The file '${opts.properties}' doesn't exist." | |||
| rc = Math.max(rc, 1) | |||
There was a problem hiding this comment.
I think you can directly assign a value to rc, it doesn't hurt to do it this way here.
Suggested change
| rc = Math.max(rc, 1) | |
| rc = 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print an error message if the packaging properties file doesn't exist.