Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] MetaMask stuck loading after app update #1212

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Fix] MetaMask stuck loading after app update #1212

wants to merge 3 commits into from
+40 −27

Conversation

BrettCleary
Copy link
Collaborator

@BrettCleary BrettCleary commented Jan 20, 2025 •
edited
Loading

Summary

closes https://github.com/HyperPlay-Gaming/product-management/issues/862

closes https://github.com/HyperPlay-Gaming/product-management/issues/867

Testing

https://app.qase.io/case/HC-529

  1. Create a new MM ext wallet
  2. Verify that the extension is in dark mode by default

@BrettCleary BrettCleary self-assigned this Jan 20, 2025
@BrettCleary BrettCleary added the PR: Ready-For-Review PR is ready to be reviewed by peers label Jan 20, 2025
@eliobricenov
Copy link
Contributor

I'm not sure if this is related to the fix but testing the artifact after having a HyperPlay version installed results in the MetaMask icon not showing up next to my avatar.

The onboarding modal doesn't show up either.

image

@BrettCleary
Copy link
Collaborator Author

I'm not sure if this is related to the fix but testing the artifact after having a HyperPlay version installed results in the MetaMask icon not showing up next to my avatar.

The onboarding modal doesn't show up either.

image

This is a separate issue. On update, you'll have to click "connect wallet" again in the account dropdown

@biliesilva
Copy link
Contributor

Sadly I can't test because I don't have a Qase account for HyperPlay :(

jiyuu-jin
jiyuu-jin approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@jiyuu-jin jiyuu-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code, LGTM

flavioislima
flavioislima approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@BrettCleary BrettCleary added PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: Ready-For-Review PR is ready to be reviewed by peers labels Jan 21, 2025
biliesilva
biliesilva approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@biliesilva biliesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working ok on Mac!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biliesilva biliesilva biliesilva approved these changes

@eliobricenov eliobricenov eliobricenov approved these changes

@flavioislima flavioislima flavioislima approved these changes

@jiyuu-jin jiyuu-jin jiyuu-jin approved these changes

@nyghtstalker nyghtstalker Awaiting requested review from nyghtstalker

Assignees

@BrettCleary BrettCleary

Labels
PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BrettCleary @eliobricenov @biliesilva @jiyuu-jin @flavioislima