Skip to content
This repository has been archived by the owner on Apr 12, 2019. It is now read-only.

Commit

Permalink
Fix various issues.
Browse files Browse the repository at this point in the history
  • Loading branch information
Alexia committed Jul 26, 2017
1 parent 8f43aaa commit 5a58679
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 23 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
#v2.0.1
* Switched over to iframes to support newer browsers.

#v2.0.0
* Converted to extension registration.
* Forcing a max-width: 100%; on the object container.
Expand Down
11 changes: 5 additions & 6 deletions PDFEmbed.hooks.php
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,14 @@ static public function generateTag($file, $args = [], Parser $parser, PPFrame $f
* @return string HTML object.
*/
static private function embed(File $file, $width, $height, $page) {
return Html::rawElement('object', [
return Html::rawElement(
'iframe',
[
'width' => $width,
'height' => $height,
'data' => $file->getFullUrl().'#page='.$page,
'type' => 'application/pdf',
'src' => $file->getFullUrl().'#page='.$page,
'style' => 'max-width: 100%;'
],
wfMessage('pdf_not_supported', $file->getFullUrl(), $file->getName())->escaped()
."<param name='page' value='$page' />"
]
);
}

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Installation
To install this extension, add the following to the end of the LocalSettings.php file:
```php
//PDFEmbed
wfLoadExtension("PDFEmbed");
wfLoadExtension('PDFEmbed');
```

Configuration
Expand Down
2 changes: 1 addition & 1 deletion extension.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "PDFEmbed",
"version": "2.0.0",
"version": "2.0.1",
"author": "Alexia E. Smith",
"url": "https://www.mediawiki.org/wiki/Extension:PDFEmbed",
"descriptionmsg": "pdfembed_description",
Expand Down
25 changes: 12 additions & 13 deletions i18n/de.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
{
"@metadata": {
"authors": [
"Messerjokke79",
"Kghbln"
]
},
"pdfembed": "PDF Embed",
"pdfembed_description": "Ermöglicht das Einbetten von PDF-Dateien",
"embed_pdf_no_permission": "Du bist nicht berechtigt PDF-Dateien einzubetten.",
"embed_pdf_blank_file": "Die URL bzw. der Dateipfad zum Einbetten der PDF-Datei ist leer.",
"embed_pdf_invalid_file": "Die URL bzw. der Dateipfad existieren nicht.",
"embed_pdf_invalid_user": "Ein ungültiger Benutzer wurde angegeben.",
"pdf_not_supported": "Die PDF-Datei wurde entweder nicht richtig geladen oder der verwendete Browser kann keine PDF-Dateien anzeigen. Die PDF-Datei <a href=\"$1\">$2</a> herunterladen."
"@metadata": {
"authors": [
"Messerjokke79",
"Kghbln"
]
},
"pdfembed": "PDF Embed",
"pdfembed_description": "Ermöglicht das Einbetten von PDF-Dateien",
"embed_pdf_no_permission": "Du bist nicht berechtigt PDF-Dateien einzubetten.",
"embed_pdf_blank_file": "Die URL bzw. der Dateipfad zum Einbetten der PDF-Datei ist leer.",
"embed_pdf_invalid_file": "Die URL bzw. der Dateipfad existieren nicht.",
"embed_pdf_invalid_user": "Ein ungültiger Benutzer wurde angegeben."
}
3 changes: 1 addition & 2 deletions i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,5 @@
"embed_pdf_no_permission": "You do not have permission to embed PDF files.",
"embed_pdf_blank_file": "The URL or file path given to embed a PDF is blank.",
"embed_pdf_invalid_file": "The URL or file path given does not exist.",
"embed_pdf_invalid_user": "An invalid user was specified to permission testing to embed this PDF.",
"pdf_not_supported": "The PDF file did not load properly or your web browser does not support viewing PDF files. Download <a href=\"$1\">$2</a> directly to your device."
"embed_pdf_invalid_user": "An invalid user was specified to permission testing to embed this PDF."
}

0 comments on commit 5a58679

Please sign in to comment.