Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OPTIC-1438: Extra logging on summary column calculation #6925

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

mcanu
Copy link
Contributor

@mcanu mcanu commented Jan 17, 2025

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

There is a flaky bug in Selenium tests where a column isn't correctly displayed after an import. I couldn't reproduce the bug, but I added some extra logs for easier troubleshooting the next time it happens.

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

@github-actions github-actions bot added the fix label Jan 17, 2025
Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 9e8c6dd
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/678a60cdb3ee560008d0ac90

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 9e8c6dd
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/678a60cde5487e0008013c81

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.94%. Comparing base (ddd5ead) to head (9e8c6dd).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6925   +/-   ##
========================================
  Coverage    76.94%   76.94%           
========================================
  Files          175      175           
  Lines        14144    14144           
========================================
  Hits         10883    10883           
  Misses        3261     3261           
Flag Coverage Δ
pytests 76.94% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcanu mcanu merged commit e0e91fd into develop Jan 17, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants