Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: OPTIC-1510: remove a batch of ff #6882

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Jan 9, 2025

Review commit by commit
A group of simple FF that were stale an we dice to remove them in the same pull request to avoid the conflict when merge.

fflag_fix_front_dev_4075_taxonomy_overlap_281222_short as True,

fflag_fix_back_lsdv_1044_check_annotations_24012023_short as False,

fflag_fix_font_lsdv_1148_hotkeys_namespaces_01022023_short as True,

fflag_feat_front_lsdv_4659_skipduplicates_060323_short as True
(skipduplicates_editing is referenced somehow here, so I take it down also in the last commit)

fflag_feat_front_lsdv_4661_full_uri_resolve_15032023_short as True
(white spaces here are relevant)

fflag_feat_front_lsdv_4712_skipduplicates_editing_110423_short as True

All of this are LSO only.

You may want to review commit by commit and with whitespace option enabled.
First commit is empty since I create a ticket to group this work

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit ce42e83
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67804bb44a43aa0008ed9b9e

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit ce42e83
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67804bb4c25fae0008e921f7

@luarmr luarmr force-pushed the fb-optic-1510/remove-a-catch-of-ff branch from 43b2b47 to f3e7ad0 Compare January 9, 2025 18:26
@luarmr luarmr changed the title Fb optic 1510/remove a catch of ff refactor: optic-1510: remove a batch of ff Jan 9, 2025
@luarmr luarmr force-pushed the fb-optic-1510/remove-a-catch-of-ff branch 2 times, most recently from 931aa7c to fa89ff6 Compare January 9, 2025 19:20
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.80%. Comparing base (8222cb5) to head (ce42e83).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6882   +/-   ##
========================================
  Coverage    76.80%   76.80%           
========================================
  Files          171      171           
  Lines        14031    14027    -4     
========================================
- Hits         10776    10774    -2     
+ Misses        3255     3253    -2     
Flag Coverage Δ
pytests 76.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luarmr luarmr force-pushed the fb-optic-1510/remove-a-catch-of-ff branch from fa89ff6 to ea22034 Compare January 9, 2025 21:42
@luarmr luarmr changed the title refactor: optic-1510: remove a batch of ff refactor: OPTIC-1510: remove a batch of ff Jan 9, 2025
@luarmr luarmr force-pushed the fb-optic-1510/remove-a-catch-of-ff branch from ea22034 to ce42e83 Compare January 9, 2025 22:20
@luarmr luarmr merged commit 3bd1210 into develop Jan 13, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants