-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: OPTIC-1510: remove a batch of ff #6882
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
luarmr
force-pushed
the
fb-optic-1510/remove-a-catch-of-ff
branch
from
January 9, 2025 18:26
43b2b47
to
f3e7ad0
Compare
luarmr
changed the title
Fb optic 1510/remove a catch of ff
refactor: optic-1510: remove a batch of ff
Jan 9, 2025
luarmr
force-pushed
the
fb-optic-1510/remove-a-catch-of-ff
branch
2 times, most recently
from
January 9, 2025 19:20
931aa7c
to
fa89ff6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6882 +/- ##
========================================
Coverage 76.80% 76.80%
========================================
Files 171 171
Lines 14031 14027 -4
========================================
- Hits 10776 10774 -2
+ Misses 3255 3253 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
luarmr
force-pushed
the
fb-optic-1510/remove-a-catch-of-ff
branch
from
January 9, 2025 21:42
fa89ff6
to
ea22034
Compare
luarmr
commented
Jan 9, 2025
luarmr
changed the title
refactor: optic-1510: remove a batch of ff
refactor: OPTIC-1510: remove a batch of ff
Jan 9, 2025
bmartel
reviewed
Jan 9, 2025
…_4075_taxonomy_overlap_281222_short
…_1044_check_annotations_24012023_short
…_1148_hotkeys_namespaces_01022023_short
…dv_4659_skipduplicates_060323_short
…dv_4661_full_uri_resolve_15032023_short
…dv_4712_skipduplicates_editing_110423_short
luarmr
force-pushed
the
fb-optic-1510/remove-a-catch-of-ff
branch
from
January 9, 2025 22:20
ea22034
to
ce42e83
Compare
luarmr
commented
Jan 9, 2025
bmartel
approved these changes
Jan 9, 2025
hlomzik
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review commit by commit
A group of simple FF that were stale an we dice to remove them in the same pull request to avoid the conflict when merge.
fflag_fix_front_dev_4075_taxonomy_overlap_281222_short
as True,fflag_fix_back_lsdv_1044_check_annotations_24012023_short
as False,fflag_fix_font_lsdv_1148_hotkeys_namespaces_01022023_short
as True,fflag_feat_front_lsdv_4659_skipduplicates_060323_short
as True(skipduplicates_editing is referenced somehow here, so I take it down also in the last commit)
fflag_feat_front_lsdv_4661_full_uri_resolve_15032023_short
as True(white spaces here are relevant)
fflag_feat_front_lsdv_4712_skipduplicates_editing_110423_short
as TrueAll of this are LSO only.
You may want to review commit by commit and with whitespace option enabled.
First commit is empty since I create a ticket to group this work