fix: LEAP-1708: improve styling for relation overlay #6875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added dynamic classes to handle highlighting, ensuring better user interaction and clarity.
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
hlomzik
reviewed
Jan 8, 2025
web/libs/editor/src/components/InteractiveOverlays/RelationsOverlay.module.scss
Outdated
Show resolved
Hide resolved
…erlay.module.scss Co-authored-by: hlomzik <[email protected]>
hlomzik
reviewed
Jan 9, 2025
| transition: opacity 300ms; | ||
| } | ||
|
|
||
| &._highlighting { |
There was a problem hiding this comment.
why do you use underscore here?
hlomzik
reviewed
Jan 9, 2025
| <title>{this.state.shouldRender ? "Arrow Marker" : ""}</title> | ||
| {this.state.shouldRender && this.renderRelations(relations, visible, hasHighlight, highlighted)} | ||
| { | ||
| // mowing a highlighted relation into the foreground |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dynamic classes to handle highlighting, ensuring better user interaction and clarity.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
It was hard to distinguish different relations when there are alot of them on the screen.
What does this fix?
This fix makes highlighted relation more visible by changing dimmed opacity and moving selected relation into the foreground.
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Relations Overlay