This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: LEAP-299: Show spinner while taxonomy's loading #1604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We combine two things:
loading
)and display spinner when flag is true.
Also styles should be adjusted to match the height of taxonomy to not jump when it's loaded.
PR fulfills these requirements
Describe the reason for change
Currently taxonomy displays No Data dropdown stub while loading. And this loading state is not indicated anyhow, confusing the user.
This change affects (describe how if yes)
What alternative approaches were there?
To modify current empty state to change phrasing. But spinner is more clear and we already have it.
The downside is that selected items are only visible after taxonomy is loaded.
What feature flags were used to cover this change?
fflag_feat_front_lsdv_5451_async_taxonomy_110823_short
Does this PR introduce a breaking change?
What level of testing was included in the change?
Which logical domain(s) does this change affect?
Taxonomy