Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LEAP-299: Show spinner while taxonomy's loading #1604

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Oct 24, 2023

We combine two things:

  • flag we already have inside taxonomy (loading)
  • spinner we already use for old taxonomy

and display spinner when flag is true.

Also styles should be adjusted to match the height of taxonomy to not jump when it's loaded.

PR fulfills these requirements

  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Describe the reason for change

Currently taxonomy displays No Data dropdown stub while loading. And this loading state is not indicated anyhow, confusing the user.

This change affects (describe how if yes)

  • Performance
  • Security
  • UX — improves loading state by indicating it clearly

What alternative approaches were there?

To modify current empty state to change phrasing. But spinner is more clear and we already have it.
The downside is that selected items are only visible after taxonomy is loaded.

What feature flags were used to cover this change?

fflag_feat_front_lsdv_5451_async_taxonomy_110823_short

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Taxonomy

@hlomzik hlomzik requested a review from farioas as a code owner October 24, 2023 23:52
Global spinner should not be displayed then, only small spinner near the item
@hlomzik hlomzik enabled auto-merge (squash) October 27, 2023 10:54
@hlomzik hlomzik merged commit 5d5d569 into master Oct 27, 2023
@hlomzik hlomzik deleted the fb-leap-299/loading-spinner branch October 27, 2023 12:21
MasherJames pushed a commit to HelloPareto/label-studio-frontend that referenced this pull request Feb 29, 2024
* fix: LEAP-299: Show spinner while taxonomy's loading

* Fix Cypress

* Remove debug and verbose from e2e

* Fix nested loadings with real api

Global spinner should not be displayed then, only small spinner near the item
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants