This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: OPTIC-108: Text on grid view should be truncated #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlomzik
approved these changes
Jan 27, 2024
| </div> | ||
| <Tooltip title={output}> | ||
| <div | ||
| style={{ padding: 5, height: TextDataGroup.height, overflow: "hidden", whiteSpace: "nowrap", textOverflow: "ellipsis" }} |
| const valueToString = (value) => { | ||
| if (typeof value === "string") return value; | ||
|
|
||
| try { | ||
| return JSON.stringify(value); | ||
| } catch { | ||
| return value.toString(); | ||
| return (value ?? "").toString(); |
There was a problem hiding this comment.
what kind of value could be here? it won't fail on null or undefined and that's the only values triggering nullish coalescing.
There was a problem hiding this comment.
it could be any non-JSON value - in this case null and undefined should render as "", while 0 and false should render as "0" and "false", every thing else should render as what ever it is, be it string, int, etc
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
minor visual tweak to truncate text in grid view. will show a tooltip on hover to show more info about truncated text