Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: DIA-640: [FE] when creating a new dataset and navigating to it tasks request will fire multiple times #274

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

yyassi-heartex
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

since Data Explorer doesnt uses the tabs interface having default view creation and new view creation calling reload only caused the tasks endpoint to fire more times than needed leading to extra load at dataset creation

@yyassi-heartex yyassi-heartex merged commit 6f05afa into master Nov 30, 2023
5 checks passed
@yyassi-heartex yyassi-heartex deleted the fb-dia-640/reduce-load branch November 30, 2023 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants