-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add helm deploy #5
Conversation
supercedes #3
also supercedes #3 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5 +/- ##
=======================================
Coverage 98.15% 98.15%
=======================================
Files 5 5
Lines 326 326
Branches 39 52 +13
=======================================
Hits 320 320
Misses 3 3
Partials 3 3 ☔ View full report in Codecov by Sentry. |
The PR should be largely ready. Can you take a look and provide some feedback? The hanging tests is likely misconfigured branch protection rules. ping @ylep and @JoelChavas edit: I don't mind (In fact, I would recommend squash and merge) the PR to keep the commit history clean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am completely ignorant of k8s and helm, so you have my full trust here, feel free to proceed with the merge!
@xgui3783 we now have container images including AimsApplyTransform
that are based on Ubuntu 22.04, I should probably prepare a Docker version so that you can finally upgrade from obsolete dependencies (Ubuntu 18.04, Python 3.6)... ? Feel free to open an issue regarding that duty, and assign it to me.
Apologies, I only just now have time to report on this PR. I can report that the spatial backend is running well on the new k8s cluster $ kubectl get all
NAME READY STATUS RESTARTS AGE
pod/busy-box-7fdc68fbfc-gbx7f 1/1 Running 1 (105d ago) 106d
pod/prod-hbp-spatial-backend-7f644f74ff-g2gpc 1/1 Running 1 (105d ago) 106d
pod/prod-hbp-spatial-backend-7f644f74ff-pxqd9 1/1 Running 6 (65d ago) 113d
pod/prod-hbp-spatial-backend-7f644f74ff-xgms9 1/1 Running 3 (65d ago) 106d
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
service/prod-hbp-spatial-backend ClusterIP 10.43.180.189 <none> 8080/TCP 113d
NAME READY UP-TO-DATE AVAILABLE AGE
deployment.apps/busy-box 1/1 1 1 113d
deployment.apps/prod-hbp-spatial-backend 3/3 3 3 113d
NAME DESIRED CURRENT READY AGE
replicaset.apps/busy-box-7fdc68fbfc 1 1 1 113d
replicaset.apps/prod-hbp-spatial-backend-7f644f74ff 3 3 3 113d
replicaset.apps/prod-hbp-spatial-backend-b865588d6 0 0 0 113d
replicaset.apps/prod-hbp-spatial-backend-bb689d979 0 0 0 113d the URL of the deployed service is at https://siibra-spatial-backend.apps.tc.humanbrainproject.eu/ , and we have a monitoring cron job running at https://github.com/FZJ-INM1-BDA/iav-dep-test/actions/workflows/siibra.dep.yml to monitor the health of the endpoint (e.g. https://github.com/FZJ-INM1-BDA/iav-dep-test/actions/runs/8295730452/job/22703360465 which monitors the new endpoint) I lack the sufficient right to merge in this repo. If you have a chance can you a/ update the merge checklist and ping @ylep |
I couldn't find a way of updating the merge checklist... hope the force-merge is fine. |
solves #4