Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use local-dev-lib for hubdb and api/hubdb #998

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Use local-dev-lib for hubdb and api/hubdb #998

merged 4 commits into from
Feb 13, 2024

Conversation

camden11
Copy link
Contributor

@camden11 camden11 commented Feb 12, 2024 •
edited
Loading

Description and Context

This updates imports of hubdb and api/hubdb to use local-dev-lib rather than cli-lib

Screenshots

TODO

Need to release changes here before merging HubSpot/hubspot-local-dev-lib#103

Who to Notify

@brandenrodgers @kemmerle

@camden11 camden11 marked this pull request as ready for review February 12, 2024 21:08
kemmerle
kemmerle approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@kemmerle kemmerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out all the commands, and everything is working great! Also good to remind myself how the hubdb CLI commands work 😅

@camden11 camden11 merged commit 48fd2ab into master Feb 13, 2024
1 check passed
@camden11 camden11 deleted the port-hubdb branch February 13, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kemmerle kemmerle kemmerle approved these changes

@brandenrodgers brandenrodgers Awaiting requested review from brandenrodgers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camden11 @kemmerle