Sandbox error handling updates #990
Conversation
| const { | ||
| isMissingScopeError, | ||
| } = require('@hubspot/local-dev-lib/errors/apiErrors'); |
There was a problem hiding this comment.
I migrated over isMissingScopeError to the LDL version since its for a sandboxes endpoint, but left isSpecifiedError as the local version. The usage of isSpecifiedError in this file is for handleProjectUpload which is still pulling uploadProject from the old @hubspot/cli-lib dependency where the http base is still request-promise-native.
Same goes for cli -> lib -> projects.js in this repo since fetchProject is also pulled in from @hubspot/cli-lib. Usage is limited to just those two in projects files - I'll leave a comment in the code to reduce any confusion once that migration happens
| isSpecifiedError(err, { | ||
| statusCode: 403, | ||
| category: 'BANNED', | ||
| subCategory: 'SandboxErrors.DEVELOPMENT_SANDBOX_ACCESS_NOT_ALLOWED', |
There was a problem hiding this comment.
Added a gating error scenario for when users are not ungated for crm-developement-beta
Description and Context
For context, a migration was made to use local-dev-lib from cli-lib and some of the error message formats have changed. The util functions we are using on hubspot-cli (eg
isSpecifiedError,isMissingScopeError) were outdated and were expecting a different error format.This PR aims to fix error handling for
hs sandboxcommands by migrating to the local-dev-lib versions of the util functions. I've also added a missing error scenario forhs sandbox createwhere users may not be ungated for development sandboxes.Required changes in local-dev-lib: HubSpot/hubspot-local-dev-lib#93
Screenshots
Before 1:
After 1:
Before 2:
After 2:
TODO
NOTE: I wasn't able to migrate
isSpecifiedErrorto the local-dev-lib version forcli/lib/projects.jsandcli/commands/project/dev.js. The APIs being called in those files still come from cli-lib and use request-promise-native so the new LDL version ofisSpecifiedErrorwont work since they're not AxiosErrors.Who to Notify
@shannon-lichtenwalter