Remove cli-lib/http dep + use local-dev-lib for OAuth #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
changed the title
| @@ -118,7 +118,7 @@ async function validateAccount(options) { | |||
| logger.error( | |||
| `The OAuth2 configuration for account ${accountId} is incorrect` | |||
| ); | |||
| logger.error('Run "hscms auth oauth2" to reauthenticate'); | |||
There was a problem hiding this comment.
Wow hscms, this really hasn't been touched in a long time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This removes three more dependancies on cli-lib modules:
httpis no longer needed (see https://hubspot.slack.com/archives/C01GV708YH3/p1706644044503449)oauthOAuth2ManagerThis also fixes a big that would cause
hs auth --type=oauth2to display an error message even when working properly.Todo
Who to Notify
@brandenrodgers