Encode theme folder when generating theme preview link #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interesting. It sounds like we're using src as the theme path. Should we use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Fixes #596
Encodes the theme folder when generating a link to the theme previewer.
Screenshots
TODO
When testing this, I did find a flaw in the way this link is generated. If the theme is uploaded to a different folder, the preview link will not be accurate. For example
hs upload "cool theme" theme2000would yield a link to/theme-previewer/1234567/edit/cool%20themewhen it should point to/theme-previewer/1234567/edit/theme2000Filed in #600
Who to Notify