Adding tests for accountTypes and buildAccount #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandenrodgers
requested review from
camden11,
kemmerle and
joe-yeager
as code owners
camden11
approved these changes
Jan 29, 2025
joe-yeager
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This adds some tests for a few more files in the lib/ folder:
I made some very small naming changes in the buildAccount.ts file because the names were slightly confusing. I also fixed a bug in
buildDeveloperTestAccountwhere we were accidentally passing in the parent account ID when callingsaveAccountToConfig. I'm hoping the more explicit naming will make these a little easier to understand.Screenshots
TODO
Who to Notify