Improve prompting behavior for hs custom-object create
#1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
requested review from
brandenrodgers,
kemmerle and
joe-yeager
as code owners
joe-yeager
previously approved these changes
Jan 7, 2025
lang/en.lyaml
Outdated
| @@ -214,8 +214,8 @@ en: | |||
| describe: "Schema name to add the object instance to" | |||
| success: | |||
| objectsCreated: "Objects created" | |||
| inputSchema: "What would you like to name the schema?" | |||
| inputPath: "[--path] Where is the JSON file containing the object definitions?" | |||
| inputName: "Enter the name of the schema for the custom object(s) you'd like to create:" | |||
There was a problem hiding this comment.
Should we prefix this with [--name]?
joe-yeager
approved these changes
Jan 7, 2025
brandenrodgers
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
We recently updated
hs custom-object createto prompt users for a custom object's name and JSON definition path when not provided. When testing, I found the way we're currently prompting to be a bit confusing. The command currently asks for the path of the JSON definitions before asking what kind of object you want to create, which seems non intuitive. The prompt for the name of the custom object type is also misleading, asking what you'd like to name your schema when you're not actually creating a schema. I've fixed both of these things.Screenshots
Before:
After:
Who to Notify
@brandenrodgers @kemmerle @joe-yeager