Fix error messaging in hs cms convert-fields #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! 🎉 this lgtm, but I'll defer to @TanyaScales for the final approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
See https://git.hubteam.com/HubSpot/hubspot-cli-issues/issues/630
We noticed during our CLI bug bash that not providing the
--srcflag tohs cms conver-fieldsleads to a misleading error message. I also noticed that providing an invalidsrcresults in a missing translation and even worse error message. This fixes both of those thingsScreenshots
No
--srcbeforeNo
--srcafterInvalid
--srcbeforeInvalid
--srcafterWho to Notify
@brandenrodgers @joe-yeager @TanyaScales