Add support for slashes for modern color syntax #82
Conversation
|
Will have a look, maybe we can do it by supporting these colors directly https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/oklch |
|
@janfaracik ok work has started, i will try to support all the recent color formats. Therefore it might require some days to do that but it will be part of the next release (hopefully still in 2024) |
|
@janfaracik @timja Do you have any chance to test this? |
|
will add relative colors (https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_colors/Relative_colors) after xmas |
I ran it against the Jan's pull request using: All passed except for one which I think is a flake, although there is at least one syntax type not being supported as we get this error: |
|
Thanks for the fast testing/feedback. Will inform you after the next update is available. |
|
@timja do you have a simple chance to extract the http://localhost:36091/jenkins/static/3349e0f4/jsbundles/styles.css file from the jenkis build run and attach it here? Will be great to use this file for testing and build a regression test out of it. |
https://gist.github.com/timja/c63ccf91b14797ec1161322a4fef046c If you want to reproduce yourself: gh repo clone jenkinsci/jenkins
cd jenkins
gh pr checkout 10078
mvn clean install -P quick-build
cd test
mvn test -Dtest=hudson.model.DirectoryBrowserSupportTest#globThe erroring CSS url will be printed in the log and if you're somewhat quick you can grab it, otherwise you can put a |
|
@timja thanks |
|
@janfaracik @timja |
Fantastic, thanks! Running now - jenkinsci/jenkins#10078 |
|
Thanks worked great, looks like my previous attempt didn't work setting a dependency management, I forgot the dependency was shaded, this worked instead: jenkinsci/jenkins-test-harness-htmlunit#173 With this diff: diff --git a/test/pom.xml b/test/pom.xml
index 5f8d44d580..2760314326 100644
--- a/test/pom.xml
+++ b/test/pom.xml
@@ -138,9 +138,9 @@ THE SOFTWARE.
</dependency>
<dependency>
- <groupId>org.htmlunit</groupId>
- <artifactId>htmlunit</artifactId>
- <version>4.8.0-SNAPSHOT</version>
+ <groupId>org.jenkins-ci.main</groupId>
+ <artifactId>jenkins-test-harness-htmlunit</artifactId>
+ <version>199.ved3a_ecd38a_5d</version>
</dependency>
</dependencies>
</dependencyManagement>Test output: |
|
Ok, great, will try to find some time to make a full HtmlUnit release this weekend |
Failed - something for me or because of other reasons? |
It’s not actually using the snapshot. Tests are unfortunately a bit flakey atm |
|
@janfaracik @timja writing more unit tests always leads to more fixes, have just deployed another new snapshot build 4.8.0-SNAPSHOT |
This is rather rudimentary so do let me know if a more complete implementation is necessary.
Having an issue when trying to modern color syntax/relative color syntax in Jenkins jenkinsci/jenkins#10078 where the tests are failing due to CSSParser flagging that
/isn't supported. This PR adds/so that it no longer fails, added a basic test to confirm too.The error is below: