-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Algebra OCL integration #81
Conversation
|b, _samples| { | ||
b.iter_batched( | ||
|| { | ||
let a: Vec<F> = load_data(num_coeffs); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why the FFT benches come with the load_data() and save_data() functions. Unlike generating points on an elliptic curve, sampling field elements is fast.
} | ||
} | ||
|
||
fn best_fft(a: &mut [F], _worker: &Worker, omega: F, log_n: u32) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect that log_n is the ceiling of log_2(domain size)?
b: Option<F>, | ||
} | ||
|
||
impl<F: PrimeField> ConstraintSynthesizer<F> for TestCircuit1<F> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should comment that TestCircuit1 has R1CS density d=1 and keeps the synthesizer costs low (no field inversion needed).
} | ||
} | ||
|
||
impl<F: PrimeField> ConstraintSynthesizer<F> for TestCircuit2<F> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here: let's comment the R1CS density d=1 and that every second constraint costs the synthesizer a field inversion (this should simulate EC arithmetics over prime fields).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change our x^5-Poseidon-128 number of partial rounds to R_p=57. This corresponds to the recommendation of the updated Poseidon paper on the IACR preprint archive.
Not topic of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside just a few comments to be resolved, everything's ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside a few comments to be resolved everything is ok.
No description provided.