Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Difference and Differentiator blocks. #6

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Conversation

Tirpitz93
Copy link
Contributor

Adds Difference and Differentiator blocks.
I think this would be best placed in the signals library in core once everyone is happy with it.

@Tirpitz93
Copy link
Contributor Author

Hopsan/hopsan#2143

@robbr48 robbr48 self-requested a review October 11, 2022 08:42
diff/diffDiff.hpp Outdated Show resolved Hide resolved
diff/diffDiff.hpp Outdated Show resolved Hide resolved
diff/diffDiff.hpp Outdated Show resolved Hide resolved
In/out Variable renamed to `in` and `out`.
Empty methods removed
Variable `prev` changed from member to private variable
Blocks renamed to `SignalDifference` & `SignalDifferentiator` respectively.
Removes redundant includes.
@robbr48 robbr48 self-requested a review October 14, 2022 07:17
Copy link
Contributor

@robbr48 robbr48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I think we can move these components to the default library quite soon, after some testing.

@robbr48 robbr48 merged commit bfe69c5 into Hopsan:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants