Purging data_path from flepiMoP
#480
Open
+174
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some files that may be concerned with CLI (rather than config keys) that we may want to revert:
|
emprzy
requested review from
pearsonca,
TimothyWillard,
saraloo and
MacdonaldJoshuaCaleb
TimothyWillard
added
documentation
TimothyWillard
added
the
next release
There was a problem hiding this comment.
I think this looks fine to me, CI passes and purges outdated concept. However, I doubt I'm the best reviewer for this, particularly the post/preprocessing scripts since those exist outside of my knowledge base at the moment. It's also not clear to me that those are commonly used today anyways.
saraloo
previously approved these changes
Jan 24, 2025
pearsonca
requested changes
Jan 27, 2025
documentation/gitbook/model-inference/inference-implementation/configuration-options.md
Outdated
Show resolved
Hide resolved
documentation/gitbook/model-inference/inference-implementation/old-configuration-setup.md
Outdated
Show resolved
Hide resolved
documentation/gitbook/more/setting-up-the-model-and-post-processing/config-writer.md
Outdated
Show resolved
Hide resolved
saraloo
dismissed
their stale review
FOund a small error in run_sim_processing_SLURM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes.
This pull request attempts to remove the deprecated configuration option
data_pathfrom flepiMoP code and documentation. I found all instances of "data_path" in flepiMoP via agrepsearch, so I may have also removeddata_pathas a CLI option, which I can revert if needed.Presently, there are still
data_pathreferences in the following files for the following reasons:data_var, which is explained as a column indata_pathand are respectively being reworked and old.What does your pull request address? Tag relevant issues.
This pull request addresses GH #472.