Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easyrpg-player: update livecheck #206254

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Conversation

samford
Copy link
Member

@samford samford commented Feb 1, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The existing livecheck block for easyrpg-player is an old check from years ago and there's no specific reason it's checking Git tags other than it technically works. This updates the livecheck block to check the first-party download page, which links to the stable tarball.

The existing `livecheck` block for `easyrpg-player` is an old check
from years ago and there's no specific reason it's checking Git tags
other than it technically works. This updates the `livecheck` block
to check the first-party download page, which links to the `stable`
tarball.
@samford samford added livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Feb 1, 2025
@github-actions github-actions bot added the icu4c ICU use is a significant feature of the PR or issue label Feb 1, 2025
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 1, 2025
Merged via the queue into master with commit 27a1b1e Feb 1, 2025
17 checks passed
@BrewTestBot BrewTestBot deleted the easyrpg-player-update-livecheck branch February 1, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. icu4c ICU use is a significant feature of the PR or issue livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants