Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnav: add PRQL support #203167

Merged
merged 2 commits into from
Jan 5, 2025
Merged

lnav: add PRQL support #203167

merged 2 commits into from
Jan 5, 2025

Conversation

ttiimm
Copy link
Contributor

@ttiimm ttiimm commented Jan 4, 2025

Update the 0.12.3 version to include PRQL querying support.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Jan 4, 2025
Formula/l/lnav.rb Outdated Show resolved Hide resolved
@carlocab carlocab changed the title lnav 0.12.3 with PRQL support lnav: add PRQL support Jan 4, 2025
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a minimal test that PRQL support has been added as expected?

@ttiimm
Copy link
Contributor Author

ttiimm commented Jan 5, 2025

Can we add a minimal test that PRQL support has been added as expected?

Sure -- added one. Prior to the change it fails with

==> Testing lnav
==> /opt/homebrew/Cellar/lnav/0.12.3/bin/lnav -V
==> /opt/homebrew/Cellar/lnav/0.12.3/bin/lnav -n -c ';from [{ col1=1 }] | take 1'
✘ error: PRQL is not supported in this build
Error: lnav: failed

Should I remove the other test case that does system bin/"lnav", "-V" in lieu of this one?

Copy link
Contributor

github-actions bot commented Jan 5, 2025

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

Update the 0.12.3 version to include PRQL querying support.
Copy link
Member

@branchvincent branchvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to keep the original test, thanks for your contribution @ttiimm 🍻!

Copy link
Contributor

github-actions bot commented Jan 5, 2025

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 5, 2025
@BrewTestBot BrewTestBot enabled auto-merge January 5, 2025 20:41
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 5, 2025
Merged via the queue into Homebrew:master with commit a2eaac4 Jan 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants