Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rqlite: set version, commit hash etc build flags #203135

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Conversation

dtrodrigues
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Closes #203123

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Jan 3, 2025
Formula/r/rqlite.rb Outdated Show resolved Hide resolved
Formula/r/rqlite.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 3, 2025
@dtrodrigues
Copy link
Member Author

I switched to git so that the commit hash would be available. The tarball could continue to be used, but then the hash would be lost.

@chenrui333
Copy link
Member

the hash is a bit of useless for release builds, we can either set empty or using tap.user.

@SMillerDev
Copy link
Member

Generally upstreams think differently about that. Let's just use the checkout.

@dtrodrigues
Copy link
Member Author

This is the output from the compiled upstream release, so I think it would make sense to mirror their values

./rqlite-v8.36.3-linux-amd64/rqlite -v
Version v8.36.3, commit 92bcff8e0b50570294c3d13f6b598821ad3daff6, branch master, built on 2024-12-27T20:06:47+0000

It also aligns with what the rqlite creator suggested: #203123 (comment)

@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 3, 2025
@otoolep
Copy link
Contributor

otoolep commented Jan 5, 2025

I added the commit hash for my own convenience, I agree it's a bit low-level for most folks. In practise it is the tag value e.g. v8.36.1 that is most important to include. So I can go either way whether you want to set it, or just leave it at unknown.

Formula/r/rqlite.rb Outdated Show resolved Hide resolved
@dtrodrigues
Copy link
Member Author

Thanks @otoolep. Since there isn't a strong desire to include the commit hash, we'll switch back to the release tarball but will still include the full version string.

@otoolep
Copy link
Contributor

otoolep commented Jan 5, 2025

LGTM.

Copy link
Contributor

github-actions bot commented Jan 5, 2025

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 5, 2025
@BrewTestBot BrewTestBot enabled auto-merge January 5, 2025 20:24
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 5, 2025
Merged via the queue into master with commit 15624a8 Jan 5, 2025
15 checks passed
@BrewTestBot BrewTestBot deleted the rqlite-version branch January 5, 2025 20:33
@otoolep
Copy link
Contributor

otoolep commented Jan 5, 2025

Thank you @dtrodrigues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rqlite: full version is missing
6 participants