librsvg 2.59.2 #202992
Open
librsvg 2.59.2 #202992
+11
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
rust
|
|
bevanjkay
force-pushed
the
bump-librsvg-2.59.2
branch
from
23e3639 to
8bebc6f
Compare
|
As of |
chenrui333
reviewed
Jan 2, 2025
chenrui333
force-pushed
the
bump-librsvg-2.59.2
branch
from
8bebc6f to
8535dbf
Compare
chenrui333
added
ready to merge
librsvg: update build and test Signed-off-by: Rui Chen <[email protected]>
chenrui333
force-pushed
the
bump-librsvg-2.59.2
branch
from
8535dbf to
b4dbc5e
Compare
github-actions
bot
added
the
automerge-skip
chenrui333
approved these changes
Jan 2, 2025
carlocab
removed
the
automerge-skip
carlocab
reviewed
Jan 2, 2025
| system "make", "install", | ||
| "gdk_pixbuf_binarydir=#{lib}/gdk-pixbuf-2.0/2.10.0/loaders", | ||
| "gdk_pixbuf_moduledir=#{lib}/gdk-pixbuf-2.0/2.10.0/loaders" | ||
| system "meson", "setup", "build", "-Dpixbuf-loader=disabled", *std_meson_args |
There was a problem hiding this comment.
-Dpixbuf-loader=disabled looks suspicious given that we used to pass --enable-pixbuf-loader=yes.
There was a problem hiding this comment.
Yea, this change looks responsible for this failure: https://github.com/Homebrew/homebrew-core/actions/runs/12585492280/job/35078161710?pr=202992#step:3:234
(<unknown>:24532): Gtk-WARNING **: 16:51:08.887: Found an icon but could not load it. Most likely gdk-pixbuf does not provide SVG support.
[2025-01-02 16:51:08.888] [gtk] [critical]
unhandled exception (type Glib::Error) in signal handler:
domain: gtk-icon-theme-error-quark
code : 0
what : Icon 'cherrytree' not present in theme Adwaita
There was a problem hiding this comment.
sounds about right, let me find another way to fix the build issue 👍
carlocab
added
test failure
carlocab
requested changes
Jan 2, 2025
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
chenrui333
added
in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created with
brew bump-formula-pr.