Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

halide 19.0.0 #201454

Merged
merged 4 commits into from
Dec 18, 2024
Merged

halide 19.0.0 #201454

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9738f45
halide 19.0.0
BrewTestBot Dec 17, 2024
0609dac
wabt: revision bump for linux bottle
chenrui333 Dec 17, 2024
7c77e5f
halide: update 19.0.0 bottle.
BrewTestBot Dec 18, 2024
7ace12e
wabt: update 1.0.36_1 bottle.
BrewTestBot Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 12 additions & 23 deletions Formula/h/halide.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
class Halide < Formula

Check notice on line 1 in Formula/h/halide.rb

View workflow job for this annotation

GitHub Actions / macOS 13-arm64

Bottle cache hit 

Bottle for halide built at f526d77abb1 (Merge c2cba8746a1cb4d622a739e2c1acd769032d4771 into 4dda18530bdbdd765c9459ea1c9384c4a0925b2d, 2024-12-18)

Check notice on line 1 in Formula/h/halide.rb

View workflow job for this annotation

GitHub Actions / macOS 14-arm64

Bottle cache hit 

Bottle for halide built at f526d77abb1 (Merge c2cba8746a1cb4d622a739e2c1acd769032d4771 into 4dda18530bdbdd765c9459ea1c9384c4a0925b2d, 2024-12-18)

Check notice on line 1 in Formula/h/halide.rb

View workflow job for this annotation

GitHub Actions / macOS 15-arm64

Bottle cache hit 

Bottle for halide built at f526d77abb1 (Merge c2cba8746a1cb4d622a739e2c1acd769032d4771 into 4dda18530bdbdd765c9459ea1c9384c4a0925b2d, 2024-12-18)

Check notice on line 1 in Formula/h/halide.rb

View workflow job for this annotation

GitHub Actions / Linux

Bottle cache hit 

Bottle for halide built at f526d77abb1 (Merge c2cba8746a1cb4d622a739e2c1acd769032d4771 into 4dda18530bdbdd765c9459ea1c9384c4a0925b2d, 2024-12-18)

Check notice on line 1 in Formula/h/halide.rb

View workflow job for this annotation

GitHub Actions / macOS 13-x86_64

Bottle cache hit 

Bottle for halide built at f526d77abb1 (Merge c2cba8746a1cb4d622a739e2c1acd769032d4771 into 4dda18530bdbdd765c9459ea1c9384c4a0925b2d, 2024-12-18)

Check notice on line 1 in Formula/h/halide.rb

View workflow job for this annotation

GitHub Actions / macOS 14-x86_64

Bottle cache hit 

Bottle for halide built at f526d77abb1 (Merge c2cba8746a1cb4d622a739e2c1acd769032d4771 into 4dda18530bdbdd765c9459ea1c9384c4a0925b2d, 2024-12-18)
desc "Language for fast, portable data-parallel computation"
homepage "https://halide-lang.org"
url "https://github.com/halide/Halide/archive/refs/tags/v18.0.0.tar.gz"
sha256 "1176b42a3e2374ab38555d9316c78e39b157044b5a8e765c748bf3afd2edb351"
url "https://github.com/halide/Halide/archive/refs/tags/v19.0.0.tar.gz"
sha256 "83bae1f0e24dc44d9d85014d5cd0474df2dd03975680894ce3fafd6e97dffee2"
license "MIT"
revision 1
head "https://github.com/halide/Halide.git", branch: "main"

livecheck do
Expand All @@ -30,39 +29,29 @@
depends_on "lld"
depends_on "llvm"
depends_on "[email protected]"
depends_on "wabt"

# Check wabt version in `dependencies/wasm/CMakeLists.txt`.
# TODO: Ask upstream to support usage of a system-provided wabt.
# TODO: Do we really need a git checkout here?
resource "wabt" do
url "https://github.com/WebAssembly/wabt.git",
tag: "1.0.33",
revision: "963f973469b45969ce198e0c86d3af316790a780"
on_macos do
depends_on "openssl@3"
end

def python3
"python3.13"
end

def install
builddir = buildpath/"build"
(builddir/"_deps/wabt-src").install resource("wabt")

site_packages = prefix/Language::Python.site_packages(python3)
rpaths = [rpath, rpath(source: site_packages/"halide")]
args = [
"-DCMAKE_INSTALL_RPATH=#{rpaths.join(";")}",
"-DHalide_INSTALL_PYTHONDIR=#{site_packages}",
"-DHalide_SHARED_LLVM=ON",
"-DPYBIND11_USE_FETCHCONTENT=OFF",
"-DFLATBUFFERS_USE_FETCHCONTENT=OFF",
"-DFETCHCONTENT_SOURCE_DIR_WABT=#{builddir}/_deps/wabt-src",
"-DCMAKE_SHARED_LINKER_FLAGS=-llldCommon",
"-DHalide_INSTALL_PYTHONDIR=#{site_packages}/halide",
"-DHalide_LLVM_SHARED_LIBS=ON",
"-DHalide_USE_FETCHCONTENT=OFF",
daeho-ro marked this conversation as resolved.
Show resolved Hide resolved
"-DWITH_TESTS=NO",
]
odie "CMAKE_SHARED_LINKER_FLAGS can be removed from `args`" if build.bottle? && version > "18.0.0"
system "cmake", "-S", ".", "-B", builddir, *args, *std_cmake_args
system "cmake", "--build", builddir
system "cmake", "--install", builddir
system "cmake", "-S", ".", "-B", "build", *args, *std_cmake_args
system "cmake", "--build", "build"
system "cmake", "--install", "build"
end

test do
Expand Down
17 changes: 12 additions & 5 deletions Formula/w/wabt.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
class Wabt < Formula

Check notice on line 1 in Formula/w/wabt.rb

View workflow job for this annotation

GitHub Actions / macOS 13-arm64

Bottle cache hit 

Bottle for wabt built at d9414101f40 (Merge 3cd242c0cc445343658fed6493d8f27c82dfb8ae into f5457c94585adf367904cd076f201a7d4133c1cb, 2024-12-17)

Check notice on line 1 in Formula/w/wabt.rb

View workflow job for this annotation

GitHub Actions / macOS 14-arm64

Bottle cache hit 

Bottle for wabt built at d9414101f40 (Merge 3cd242c0cc445343658fed6493d8f27c82dfb8ae into f5457c94585adf367904cd076f201a7d4133c1cb, 2024-12-17)

Check notice on line 1 in Formula/w/wabt.rb

View workflow job for this annotation

GitHub Actions / macOS 15-arm64

Bottle cache hit 

Bottle for wabt built at d9414101f40 (Merge 3cd242c0cc445343658fed6493d8f27c82dfb8ae into f5457c94585adf367904cd076f201a7d4133c1cb, 2024-12-17)

Check notice on line 1 in Formula/w/wabt.rb

View workflow job for this annotation

GitHub Actions / Linux

Bottle cache hit 

Bottle for wabt built at d9414101f40 (Merge 3cd242c0cc445343658fed6493d8f27c82dfb8ae into f5457c94585adf367904cd076f201a7d4133c1cb, 2024-12-17)

Check notice on line 1 in Formula/w/wabt.rb

View workflow job for this annotation

GitHub Actions / macOS 13-x86_64

Bottle cache hit 

Bottle for wabt built at d9414101f40 (Merge 3cd242c0cc445343658fed6493d8f27c82dfb8ae into f5457c94585adf367904cd076f201a7d4133c1cb, 2024-12-17)

Check notice on line 1 in Formula/w/wabt.rb

View workflow job for this annotation

GitHub Actions / macOS 14-x86_64

Bottle cache hit 

Bottle for wabt built at d9414101f40 (Merge 3cd242c0cc445343658fed6493d8f27c82dfb8ae into f5457c94585adf367904cd076f201a7d4133c1cb, 2024-12-17)
desc "Web Assembly Binary Toolkit"
homepage "https://github.com/WebAssembly/wabt"
url "https://github.com/WebAssembly/wabt.git",
tag: "1.0.36",
revision: "3e826ecde1adfba5f88d10d361131405637e65a3"
license "Apache-2.0"
revision 1

livecheck do
url :stable
Expand All @@ -28,11 +29,17 @@
uses_from_macos "python" => :build

def install
system "cmake", "-S", ".", "-B", "build",
"-DBUILD_TESTS=OFF",
"-WITH_WASI=ON",
*std_cmake_args,
"-DFETCHCONTENT_FULLY_DISCONNECTED=OFF" # FIXME: Find a way to build without this.
ENV.append_to_cflags "-fPIC" if OS.linux?

args = %w[
-DBUILD_TESTS=OFF
-DWITH_WASI=ON
-DFETCHCONTENT_FULLY_DISCONNECTED=OFF
]

system "cmake", *args, *std_cmake_args

Comment on lines +38 to +39
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step seems redundant?

system "cmake", "-S", ".", "-B", "build", *args, *std_cmake_args
system "cmake", "--build", "build"
system "cmake", "--install", "build"
end
Expand Down
Loading