h*: migrate to pkgconf (part 1)

Formula/h/h2o.rb

@@ -1,4 +1,4 @@
 class H2o < Formula
   desc "HTTP server with support for HTTP/1.x and HTTP/2"
   homepage "https://github.com/h2o/h2o/"
   url "https://github.com/h2o/h2o/archive/refs/tags/v2.2.6.tar.gz"
@@ -20,7 +20,7 @@
   end
 
   depends_on "cmake" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "openssl@3"
 
   uses_from_macos "zlib"
@@ -81,11 +81,8 @@
   test do
     port = free_port
     (testpath/"h2o.conf").write conf_example(port)
-    fork do
-      exec "#{bin}/h2o -c #{testpath}/h2o.conf"
-    end
+    spawn "#{bin}/h2o -c #{testpath}/h2o.conf"
     sleep 2
-
     assert_match "Welcome to H2O", shell_output("curl localhost:#{port}")
   end
 end

Formula/h/hackrf.rb

@@ -1,4 +1,4 @@
 class Hackrf < Formula
   desc "Low cost software radio platform"
   homepage "https://github.com/greatscottgadgets/hackrf"
   url "https://github.com/greatscottgadgets/hackrf/releases/download/v2024.02.1/hackrf-2024.02.1.tar.xz"
@@ -23,22 +23,16 @@
   end
 
   depends_on "cmake" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "fftw"
   depends_on "libusb"
 
   def install
-    cd "host" do
-      args = std_cmake_args
+    args = OS.linux? ? ["-DUDEV_RULES_GROUP=plugdev", "-DUDEV_RULES_PATH=#{lib}/udev/rules.d"] : []
 
-      if OS.linux?
-        args << "-DUDEV_RULES_GROUP=plugdev"
-        args << "-DUDEV_RULES_PATH=#{lib}/udev/rules.d"
-      end
-
-      system "cmake", ".", *args
-      system "make", "install"
-    end
+    system "cmake", "-S", "host", "-B", "build", *args, *std_cmake_args
+    system "cmake", "--build", "build"
+    system "cmake", "--install", "build"
     pkgshare.install "firmware-bin/"
   end
 

Formula/h/hamlib.rb

@@ -1,4 +1,4 @@
 class Hamlib < Formula
   desc "Ham radio control libraries"
   homepage "http://www.hamlib.org/"
   url "https://github.com/Hamlib/Hamlib/releases/download/4.5.5/hamlib-4.5.5.tar.gz"
@@ -21,7 +21,7 @@
 
   depends_on "autoconf" => :build
   depends_on "automake" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "libtool"
   depends_on "libusb"
   depends_on "libusb-compat"
@@ -30,8 +30,6 @@
     depends_on "readline"
   end
 
-  fails_with gcc: "5"
-
   def install
     system "./bootstrap" if build.head?
     system "./configure", "--disable-silent-rules", *std_configure_args

Formula/h/handbrake.rb

@@ -1,4 +1,4 @@
 class Handbrake < Formula
   desc "Open-source video transcoder available for Linux, Mac, and Windows"
   homepage "https://handbrake.fr/"
   url "https://github.com/HandBrake/HandBrake/releases/download/1.7.3/HandBrake-1.7.3-source.tar.bz2"
@@ -23,7 +23,7 @@
   depends_on "meson" => :build
   depends_on "nasm" => :build
   depends_on "ninja" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "yasm" => :build
 
   uses_from_macos "m4" => :build

Formula/h/harfbuzz.rb

@@ -1,4 +1,4 @@
 class Harfbuzz < Formula
   desc "OpenType text shaping engine"
   homepage "https://github.com/harfbuzz/harfbuzz"
   url "https://github.com/harfbuzz/harfbuzz/archive/refs/tags/10.1.0.tar.gz"
@@ -18,7 +18,7 @@
   depends_on "gobject-introspection" => :build
   depends_on "meson" => :build
   depends_on "ninja" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "[email protected]" => [:build, :test]
   depends_on "pygobject3" => :test
   depends_on "cairo"
@@ -46,7 +46,7 @@
       -Dtests=disabled
     ]
 
-    system "meson", "setup", "build", *std_meson_args, *args
+    system "meson", "setup", "build", *args, *std_meson_args
     system "meson", "compile", "-C", "build", "--verbose"
     system "meson", "install", "-C", "build"
   end

Formula/h/haxe.rb

@@ -1,4 +1,4 @@
 class Haxe < Formula
   desc "Multi-platform programming language"
   homepage "https://haxe.org/"
   license all_of: ["GPL-2.0-or-later", "MIT"]
@@ -38,7 +38,7 @@
   depends_on "cmake" => :build
   depends_on "ocaml" => :build
   depends_on "opam" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "mbedtls"
   depends_on "neko"
   depends_on "pcre2"

Formula/h/hcxtools.rb

@@ -1,4 +1,4 @@
 class Hcxtools < Formula
   desc "Utils for conversion of cap/pcap/pcapng WiFi dump files"
   homepage "https://github.com/ZerBea/hcxtools"
   url "https://github.com/ZerBea/hcxtools/archive/refs/tags/6.3.5.tar.gz"
@@ -15,7 +15,7 @@
     sha256 cellar: :any_skip_relocation, x86_64_linux:  "cfa435ef982fe30b6e3ea26c1d736882a4799c0ee035bccb5cf20bdca00740dd"
   end
 
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "openssl@3"
 
   uses_from_macos "curl"

Formula/h/hdf5-mpi.rb

@@ -1,4 +1,4 @@
 class Hdf5Mpi < Formula
   desc "File format designed to store large amounts of data"
   homepage "https://www.hdfgroup.org/solutions/hdf5/"
   url "https://github.com/HDFGroup/hdf5/releases/download/hdf5_1.14.5/hdf5-1.14.5.tar.gz"
@@ -23,7 +23,7 @@
   depends_on "gcc" # for gfortran
   depends_on "libaec"
   depends_on "open-mpi"
-  depends_on "pkg-config"
+  depends_on "pkgconf"
 
   uses_from_macos "zlib"
 

Formula/h/hdf5.rb

@@ -1,4 +1,4 @@
 class Hdf5 < Formula
   desc "File format designed to store large amounts of data"
   homepage "https://www.hdfgroup.org/solutions/hdf5/"
   url "https://github.com/HDFGroup/hdf5/releases/download/hdf5_1.14.5/hdf5-1.14.5.tar.gz"
@@ -26,7 +26,7 @@
   depends_on "cmake" => :build
   depends_on "gcc" # for gfortran
   depends_on "libaec"
-  depends_on "pkg-config"
+  depends_on "pkgconf"
 
   uses_from_macos "zlib"
 

Formula/h/hdt.rb

@@ -1,4 +1,4 @@
 class Hdt < Formula
   desc "Header Dictionary Triples (HDT) is a compression format for RDF data"
   homepage "https://github.com/rdfhdt/hdt-cpp"
   url "https://github.com/rdfhdt/hdt-cpp/archive/refs/tags/v1.3.3.tar.gz"
@@ -24,7 +24,7 @@
   depends_on "autoconf" => :build
   depends_on "automake" => :build
   depends_on "libtool" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "serd"
 
   uses_from_macos "zlib"
@@ -55,7 +55,7 @@
     EOS
 
     system bin/"rdf2hdt", test_file, "test.hdt"
-    assert_predicate testpath/"test.hdt", :exist?
+    assert_path_exists testpath/"test.hdt"
     system bin/"hdtInfo", "test.hdt"
   end
 end

Formula/h/healpix.rb

@@ -1,4 +1,4 @@
 class Healpix < Formula
   desc "Hierarchical Equal Area isoLatitude Pixelization of a sphere"
   homepage "https://healpix.jpl.nasa.gov"
   url "https://downloads.sourceforge.net/project/healpix/Healpix_3.83/Healpix_3.83_2024Nov13.tar.gz"
@@ -18,7 +18,7 @@
   depends_on "autoconf" => :build
   depends_on "automake" => :build
   depends_on "libtool" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "cfitsio"
 
   def install

Formula/h/heimdal.rb

@@ -1,4 +1,4 @@
 class Heimdal < Formula
   desc "Free Kerberos 5 implementation"
   homepage "https://www.h5l.org"
   url "https://github.com/heimdal/heimdal/releases/download/heimdal-7.8.0/heimdal-7.8.0.tar.gz"
@@ -38,7 +38,7 @@
   uses_from_macos "libxcrypt"
 
   on_linux do
-    depends_on "pkg-config" => :build
+    depends_on "pkgconf" => :build
   end
 
   resource "JSON" do

Formula/h/hfstospell.rb

@@ -23,7 +23,7 @@ class Hfstospell < Formula
   depends_on "autoconf" => :build
   depends_on "automake" => :build
   depends_on "libtool" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "icu4c@76"
   depends_on "libarchive"
 

Formula/h/hidapi.rb

@@ -20,7 +20,7 @@ class Hidapi < Formula
   end
 
   depends_on "cmake" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
 
   on_linux do
     depends_on "libusb"

Formula/h/highlight.rb

@@ -21,11 +21,9 @@ class Highlight < Formula
   end
 
   depends_on "boost" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
   depends_on "lua"
 
-  fails_with gcc: "5" # needs C++17
-
   def install
     conf_dir = etc/"highlight/" # highlight needs a final / for conf_dir
     system "make", "PREFIX=#{prefix}", "conf_dir=#{conf_dir}"

Formula/h/highs.rb

@@ -23,14 +23,14 @@ class Highs < Formula
   end
 
   depends_on "cmake" => :build
-  depends_on "pkg-config" => :build
+  depends_on "pkgconf" => :build
 
   uses_from_macos "zlib"
 
   def install
     system "cmake", "-S", ".", "-B", "build",
-                    *std_cmake_args,
-                    "-DCMAKE_INSTALL_RPATH=#{rpath}"
+                    "-DCMAKE_INSTALL_RPATH=#{rpath}",
+                    *std_cmake_args
     system "cmake", "--build", "build"
     system "cmake", "--install", "build"
     pkgshare.install "check", "examples"