-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubetail 0.0.6 #195821
kubetail 0.0.6 #195821
Conversation
309ef64
to
6dd822c
Compare
Pinned to because of error:
|
Formula/k/kubetail.rb
Outdated
@@ -21,7 +21,7 @@ class Kubetail < Formula | |||
|
|||
depends_on "go" => :build | |||
depends_on "make" => :build | |||
depends_on "node" => :build | |||
depends_on "node@22" => :build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe also log an upstream issue for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked upstream for an issue or PR, but found none.
Doesn't feel right to report an issue which isn't really an issue yet, and node 22 will be supported longer than 23:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it would be very much a feature request tbh :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, @amorey is already fixing it in upstream
supposedly coming in 0.0.7 release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying 0.0.7 with the fix in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up about the problem. I patched the bug and published a new version (0.0.7) which should compile with Node 23. The source of the error was a tailwind config issue which was resolved by updating the config file format from commonjs to typescript.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amorey! 🍻
6dd822c
to
0f2728c
Compare
Created by
brew bump
Created with
brew bump-formula-pr
.