-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rqlite: set version, commit hash etc build flags #203135
Conversation
I switched to git so that the commit hash would be available. The tarball could continue to be used, but then the hash would be lost. |
the hash is a bit of useless for release builds, we can either set empty or using tap.user. |
Generally upstreams think differently about that. Let's just use the checkout. |
This is the output from the compiled upstream release, so I think it would make sense to mirror their values
It also aligns with what the |
a29874f
to
23a1bdd
Compare
I added the commit hash for my own convenience, I agree it's a bit low-level for most folks. In practise it is the tag value e.g. v8.36.1 that is most important to include. So I can go either way whether you want to set it, or just leave it at |
Thanks @otoolep. Since there isn't a strong desire to include the commit hash, we'll switch back to the release tarball but will still include the full version string. |
23a1bdd
to
836e6cd
Compare
836e6cd
to
0ed95d7
Compare
LGTM. |
🤖 An automated task has requested bottles to be published to this PR. |
Thank you @dtrodrigues |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Closes #203123