Changed preferred SourceForge URL #12486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should still leave the instructions to the latest download url, even if they’re moved under the version-specific one. I seem to remember some casks that you still couldn’t get an unersioned package, so it should remain as a possibility. |
scribblemaniac
force-pushed
the
update-contributing-sourceforge
branch
from
0756ffa to
f8aa4ef
Compare
scribblemaniac
force-pushed
the
update-contributing-sourceforge
branch
from
f8aa4ef to
f8511bc
Compare
|
I have updated this accordingly. |
|
Thank you for the contribution. It was merged directly as 9e1467c to keep commit history cleaner. Your contribution is still credited to you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #4678 and #1021, this project is aiming to reduce/eliminate the use of
version :latest. It seems to me like a natural step to achieving this goal would be using versioned sourceforge urls rather than their latest downloads. This will also help prevent potential issues with mac applications that add a windows version after the cask has been created (unlikely but certainly possible).If this change ends up getting pulled, I'll handle updating the casks currently using sourceforge latest urls to versioned urls.