set validation mode to warning for telefon numbers (#119)

* set validation mode to warning for telefon numbers * update test for bad data set * set validation mode for geburtstag und Anrede to warning
Hochfrequenz · May 31, 2024 · 3d8d70e · 3d8d70e
1 parent 68ca826
commit 3d8d70e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/src/pvtool/customer_loader.py b/src/pvtool/customer_loader.py
@@ -21,6 +21,7 @@
     ValidationManager,
     Validator,
 )
+from pvframework.errors import ValidationMode
 from pvframework.types import SyncValidatorFunction
 from pvframework.utils import param, required_field
 from pytz import timezone
@@ -357,7 +358,8 @@ def customer_validation_manager(self, config: MigrationConfig) -> ValidationMana
             config, manager_id="CustomerLoader"
         )
         customer_manager.register(
-            PathMappedValidator(validate_geschaeftspartner_anrede, {"anrede": "geschaeftspartner.anrede"})
+            PathMappedValidator(validate_geschaeftspartner_anrede, {"anrede": "geschaeftspartner.anrede"}),
+            mode=ValidationMode.WARNING,
         )
         customer_manager.register(PathMappedValidator(validate_str_is_stripped, {"string": "geschaeftspartner.name1"}))
         customer_manager.register(PathMappedValidator(validate_str_is_stripped, {"string": "geschaeftspartner.name2"}))
@@ -376,16 +378,20 @@ def customer_validation_manager(self, config: MigrationConfig) -> ValidationMana
         customer_manager.register(
             PathMappedValidator(
                 validate_geschaeftspartner_geburtsdatum, {"geburtsdatum": "geschaeftspartner.geburtstag"}
-            )
+            ),
+            mode=ValidationMode.WARNING,
         )
         customer_manager.register(
-            PathMappedValidator(validate_telefonnummer, {"telefonnummer": "geschaeftspartner.telefonnummer_privat"})
+            PathMappedValidator(validate_telefonnummer, {"telefonnummer": "geschaeftspartner.telefonnummer_privat"}),
+            mode=ValidationMode.WARNING,
         )
         customer_manager.register(
-            PathMappedValidator(validate_telefonnummer, {"telefonnummer": "geschaeftspartner.telefonnummer_geschaeft"})
+            PathMappedValidator(validate_telefonnummer, {"telefonnummer": "geschaeftspartner.telefonnummer_geschaeft"}),
+            mode=ValidationMode.WARNING,
         )
         customer_manager.register(
-            PathMappedValidator(validate_telefonnummer, {"telefonnummer": "geschaeftspartner.telefonnummer_mobil"})
+            PathMappedValidator(validate_telefonnummer, {"telefonnummer": "geschaeftspartner.telefonnummer_mobil"}),
+            mode=ValidationMode.WARNING,
         )
         customer_manager.register(
             QueryMappedValidator(

diff --git a/unittests/test_validation_customer.py b/unittests/test_validation_customer.py
@@ -182,10 +182,7 @@ async def test_good_data_set(self, customer_validation_manager):
                     "geschaeftspartner.name3 must be one of the following",
                     "The part after the @-sign is not valid. It should have a period",  # E-Mail
                     "No ExterneReferenz with name customerID",
-                    "geschaeftspartner.geburtstag must be in the range of",
                     "geschaeftspartner.erstellungsdatum must be in the past",
-                    "geschaeftspartner.anrede must be one of the following",
-                    "geschaeftspartner.telefonnummer_mobil does not match the regex pattern for phone numbers",
                     "liefer_adressen[contract_id=contract_id_1].landescode must be 'DE'",
                     "liefer_adressen[contract_id=contract_id_2].postleitzahl must consist of 5 digits",
                     "rechnungs_adressen[contract_id=contract_id_1].postleitzahl is invalid",