generated from OLILHR/sveltekit-static-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add filter elements to separate panel below header #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 31, 2025
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-water-047c71203-217.westeurope.5.azurestaticapps.net |
hf-kklein
approved these changes
Feb 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) filter disabled wenn keine FV ausgewählt ist
![image](https://private-user-images.githubusercontent.com/144932831/408750039-7c51e0a3-742f-46b7-9ea4-1a73eba4bb3a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNTMxMDksIm5iZiI6MTczOTE1MjgwOSwicGF0aCI6Ii8xNDQ5MzI4MzEvNDA4NzUwMDM5LTdjNTFlMGEzLTc0MmYtNDZiNy05ZWE0LTFhNzNlYmE0YmIzYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMFQwMjAwMDlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mZGRjOTI2NjI3ZjBlNDg0ODE3NjcwMDU3NWYwNjFkYmY4MTk5YTk5ZmUxMjQyNDBlYTg0NDhmZjQxNzUzNDIxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.wx3g_zfmpmSRHhR0-RLNnKLvkMRw2xPC5yuvhufB5Zw)
![image](https://private-user-images.githubusercontent.com/144932831/408750089-1bf363d0-7c4b-41e1-aaad-2dfe4c26c280.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNTMxMDksIm5iZiI6MTczOTE1MjgwOSwicGF0aCI6Ii8xNDQ5MzI4MzEvNDA4NzUwMDg5LTFiZjM2M2QwLTdjNGItNDFlMS1hYWFkLTJkZmU0YzI2YzI4MC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMFQwMjAwMDlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lM2Q2ZWExNzVlYjMwZmU4NDg4YjkzYTI2NTUzMjBlY2MyMzNiOTAyYzJkYjg4MzM2ZThhMDY2YWNhMTZjMjM1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.jW8n850twOnZa_M8l4pIEngwCq8aEQrO0UdR_zlyrCs)
![image](https://private-user-images.githubusercontent.com/144932831/408750157-d851f75c-1915-43a5-b485-9b24fcecafd3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNTMxMDksIm5iZiI6MTczOTE1MjgwOSwicGF0aCI6Ii8xNDQ5MzI4MzEvNDA4NzUwMTU3LWQ4NTFmNzVjLTE5MTUtNDNhNS1iNDg1LTliMjRmY2VjYWZkMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMFQwMjAwMDlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hZTUxOGIwYmE0MGExMjcyMDVhZDQ4ZjhiMTkzZjUyOWE1NWQ0YTc2ZDljZGQzMGIxNDNiZGEzNDFkMzZkZTVkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.qeALm2GJ3ElFif7lfEm7ukpahdpy-j-dGl65rBJWOHk)
![image](https://private-user-images.githubusercontent.com/144932831/408742841-970d660a-4f8d-4a3e-8db7-e526898fac78.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNTMxMDksIm5iZiI6MTczOTE1MjgwOSwicGF0aCI6Ii8xNDQ5MzI4MzEvNDA4NzQyODQxLTk3MGQ2NjBhLTRmOGQtNGEzZS04ZGI3LWU1MjY4OThmYWM3OC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMFQwMjAwMDlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01YTBlNjA0YWNiMjdmNzFhNjM0N2U4ODdhOGEwMTQ1YTMxZGJmZDU2MDU5NWZjMjM5YTU5MWRhNTViMDk0MzhmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.3NnbWS426_9uaKc3kBrgSSvZiuhNPOtlQj7IESnr9I4)
![image](https://private-user-images.githubusercontent.com/144932831/408741261-b20e5eac-35fd-493f-a4c3-c9d3f5875e7c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNTMxMDksIm5iZiI6MTczOTE1MjgwOSwicGF0aCI6Ii8xNDQ5MzI4MzEvNDA4NzQxMjYxLWIyMGU1ZWFjLTM1ZmQtNDkzZi1hNGMzLWM5ZDNmNTg3NWU3Yy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMFQwMjAwMDlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05OTQ4NjVmNDgwMDhiNWIyYjg5YzhjNmU5YWVjYjcxMGE2NjkxNjU1ZDg2MGU3YWM5NjhiMjlkYzg5NzZiOWViJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.OtiNYhCidiEnG4hCyG27ceyXoB2MCOKSqYZVXj6UyuY)
(2) filter enabled wenn FV ausgewählt ist
(3) filter icon ändert sich wenn filter panel ausgeklappt wird
(4) selected filter options (pills) erzeugen keinen linebreak mehr (daher die scrollbar)
(5) z-index: header > filter panel > svg
wäre jetzt erst mal eine Übergangslösung den überfüllten Header zu entlasten (wer nutzt schon die Filter? 😬).
für Release ist das auf alle Fälle hinreichend würde ich sagen; und nebenbei auch unser letztes feature auf dem VTB.