Update MANIFEST.in #197
Merged
Update MANIFEST.in #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namurphy
commented
Oct 13, 2023
namurphy
commented
Oct 13, 2023
namurphy
commented
Oct 13, 2023
namurphy
commented
Oct 13, 2023
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Because of problems related to the size of the package we need to exclude the example data. However, there is no currently available data source to download it from. Hence for now we need to exclude these notebooks from the release.
|
pre-commit.ci autofix |
namurphy
commented
Oct 27, 2023
…that pruned the example_data directory
wtbarnes
reviewed
Oct 30, 2023
wtbarnes
reviewed
Oct 30, 2023
There was a problem hiding this comment.
I think this should fix your RtD build. It's better to just add sunpy[net] as a single dependency rather than specifying each dependency needed to use Fido. This will also "future-proof" you against this happening again if the upstream dependencies needed to run Fido happen to change.
wtbarnes
reviewed
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.