-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add rss guide #43
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of assumptions I made!
site: 'https://www.example.com' | ||
starlight({ | ||
social: { | ||
rss: 'https://www.example.com/blog/rss.xml', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I don't know whether this URL needs to be absolute or not!
|
||
This will create a `.xml` file for feed readers and add the standard RSS icon to your website's header. | ||
|
||
Learn more about RSS feeds in Astro, including how to [enable RSS feed auto-discovery](https://docs.astro.build/en/guides/rss/#enabling-rss-feed-auto-discovery) in the official Astro documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose to link back to Astro here because this page also has more generic RSS info at external links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, I really appreciate the changes you made. 🙌
I hope you won't mind, I made a few extra changes based on your feedback and the Discord discussion:
- I moved your entire new section to a dedicated RSS guide (I always find that my plugins docs sidebar are kind of empty so I thought it was a good opportunity to add a new page)
- I added a new intro section describing exactly what is happening behind the scenes as it was not obvious at all (e.g. RSS auto-discovery is automatically configured by the plugin)
Describe the pull request
This adds a section at the bottom of the main docs page for setting up the RSS feed.
Why
Although RSS will be enabled with only the
site
property configured, setting this up fully on the site the way people would expect isn't obvious without some guidance:Explicitly telling people what the feed URL is: it's not clear at which address the feed will exist. (
feed.xml
?rss.xml
?) And, it's also not obvious that it exists at/blog/
.Adding the RSS icon in the header: most people will want the standard icon to show up, and this requires following Starlight's instructions to do so.
How
This is a description of the steps I took to fully add RSS to my site, in the way a blog owner would expect.
Screenshots