Fix a 404 RSS feed sidebar link error (#47)

HiDeoo · May 12, 2024 · cb66c21 · cb66c21
2 parents 1a22390 + 8e1d50e
commit cb66c21
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 1 deletion.
diff --git a/packages/starlight-blog/overrides/Sidebar.astro b/packages/starlight-blog/overrides/Sidebar.astro
@@ -77,7 +77,7 @@ if (isBlog) {
     blogSidebar.push({
       attrs: {},
       badge: undefined,
-      href: getBlogPathWithBase('/rss.xml'),
+      href: getBlogPathWithBase('/rss.xml', true),
       isCurrent: false,
       label: 'RSS',
       type: 'link',

diff --git a/packages/starlight-blog/tests/unit/basics/page.test.ts b/packages/starlight-blog/tests/unit/basics/page.test.ts
@@ -10,6 +10,10 @@ describe('getBlogPathWithBase', () => {
   test('returns a blog post path', () => {
     expect(getBlogPathWithBase('/post-1')).toBe('/blog/post-1')
   })
+
+  test('returns the RSS feed path', () => {
+    expect(getBlogPathWithBase('/rss.xml', true)).toBe('/blog/rss.xml')
+  })
 })
 
 describe('getPathWithBase', () => {

diff --git a/packages/starlight-blog/tests/unit/prefix/page.test.ts b/packages/starlight-blog/tests/unit/prefix/page.test.ts
@@ -10,4 +10,8 @@ describe('getBlogPathWithBase', () => {
   test('returns a blog post path', () => {
     expect(getBlogPathWithBase('/post-1')).toBe('/news/post-1')
   })
+
+  test('returns the RSS feed path', () => {
+    expect(getBlogPathWithBase('/rss.xml', true)).toBe('/news/rss.xml')
+  })
 })
diff --git a/packages/starlight-blog/tests/unit/trailing-slash-always/page.test.ts b/packages/starlight-blog/tests/unit/trailing-slash-always/page.test.ts
@@ -10,6 +10,10 @@ describe('getBlogPathWithBase', () => {
   test('returns a blog post path', () => {
     expect(getBlogPathWithBase('/post-1')).toBe('/blog/post-1/')
   })
+
+  test('returns the RSS feed path', () => {
+    expect(getBlogPathWithBase('/rss.xml', true)).toBe('/blog/rss.xml')
+  })
 })
 
 describe('getPathWithBase', () => {

diff --git a/packages/starlight-blog/tests/unit/trailing-slash-never/page.test.ts b/packages/starlight-blog/tests/unit/trailing-slash-never/page.test.ts
@@ -10,6 +10,10 @@ describe('getBlogPathWithBase', () => {
   test('returns a blog post path', () => {
     expect(getBlogPathWithBase('/post-1/')).toBe('/blog/post-1')
   })
+
+  test('returns the RSS feed path', () => {
+    expect(getBlogPathWithBase('/rss.xml', true)).toBe('/blog/rss.xml')
+  })
 })
 
 describe('getPathWithBase', () => {