Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prettier for formatting #324

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use prettier for formatting #324

wants to merge 3 commits into from

Conversation

selbekk
Copy link
Collaborator

@selbekk selbekk commented Mar 27, 2017

One thing that bothered me a bit when I created my first PR was that I used a VERY different code style than the original author (sorry @HenrikJoreteg - still love you!). prettier fixes code style on commit (or on save through some editor plugins), which would probably be a great help for future contributors (and myself).

I'm totally for discussing the rules I set up though, so please give me some feedback =)

selbekk added 3 commits March 27, 2017 22:16
This commit adds the configuration to automatically run prettier
with some sane configuration options
@selbekk selbekk requested a review from HenrikJoreteg March 27, 2017 20:21
@HenrikJoreteg
Copy link
Owner

No need to apologize :)

My main feeling on formatting is that I don't like spending time discussing it, lol. Honestly if there's some consensus for something else i guess that's fine. But unless there's compelling reason to move away from standard, I'd rather not, personally, but I'm also not the one doing maintenance on this right now so... /me shrugs.

@selbekk
Copy link
Collaborator Author

selbekk commented Apr 4, 2017

@HenrikJoreteg the beauty of prettier is that it is opinionated as hell and lets us skip that discussion completely. I'll tweak the settings a bit later before merging, to make sure we've hit the right ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants