Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update histograms for latest napari-matplotlib version #44

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

K-Meech
Copy link
Contributor

@K-Meech K-Meech commented Jan 26, 2024

For #40

This PR updates all histogram images + text to match the newest version of napari-matplotlib. In the newest version:

  • The spiky histograms are fixed (now integer bins are used for integer images)
  • We no longer need to change napari's theme, as the axis label colours are fixed
  • The histograms now show vertical white lines at the current contrast limits

@K-Meech K-Meech requested a review from davecash75 January 26, 2024 10:05
Copy link

github-actions bot commented Jan 26, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/HealthBioscienceIDEAS/microscopy-novice/compare/md-outputs..md-outputs-PR-44

The following changes were observed in the rendered markdown documents:

 fig/coins-histogram.png   | Bin 13035 -> 14079 bytes
 fig/mitosis-histogram.png | Bin 13295 -> 13752 bytes
 fig/rgb-histogram.png     | Bin 20570 -> 20428 bytes
 image-display.md          |  17 +++++++----------
 md5sum.txt                |   4 ++--
 5 files changed, 9 insertions(+), 12 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-01-26 10:06:54 +0000

github-actions bot pushed a commit that referenced this pull request Jan 26, 2024
Copy link
Contributor

@davecash75 davecash75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so much better! Note a minor suggestion of red green blue in the legend of one histogram, but if that is a real pain to do, go ahead and merge as is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How easy would it be to change the legend to red green blue instead of rgb?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a quick look, and there doesn't seem to be an easy way to change the legend via napari-matplotlib. Seems this would require further changes directly to the napari-matplotlib plugin - so I'll go ahead and merge for now. If adjusting the legend is something we need in future, we can always open another issue on the napari-matplotlib repo.

@K-Meech K-Meech merged commit 3eae9cf into main Jan 31, 2024
3 checks passed
@K-Meech K-Meech deleted the histogram_updates branch January 31, 2024 09:33
github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
Auto-generated via {sandpaper}
Source  : 3eae9cf
Branch  : main
Author  : Kimberly Meechan <[email protected]>
Time    : 2024-01-31 09:33:26 +0000
Message : Merge pull request #44 from HealthBioscienceIDEAS/histogram_updates

Update histograms for latest napari-matplotlib version
github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
Auto-generated via {sandpaper}
Source  : 7ce73de
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-01-31 09:34:46 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 3eae9cf
Branch  : main
Author  : Kimberly Meechan <[email protected]>
Time    : 2024-01-31 09:33:26 +0000
Message : Merge pull request #44 from HealthBioscienceIDEAS/histogram_updates

Update histograms for latest napari-matplotlib version
@davecash75
Copy link
Contributor

Let's go ahead with it as now, but maybe we should open up an issue with napari-matplotlib. It doesn't need to be a blocker though.

github-actions bot pushed a commit that referenced this pull request Feb 6, 2024
Auto-generated via {sandpaper}
Source  : 3eae9cf
Branch  : main
Author  : Kimberly Meechan <[email protected]>
Time    : 2024-01-31 09:33:26 +0000
Message : Merge pull request #44 from HealthBioscienceIDEAS/histogram_updates

Update histograms for latest napari-matplotlib version
github-actions bot pushed a commit that referenced this pull request Feb 6, 2024
Auto-generated via {sandpaper}
Source  : 6c4f9a1
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-02-06 00:14:58 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 3eae9cf
Branch  : main
Author  : Kimberly Meechan <[email protected]>
Time    : 2024-01-31 09:33:26 +0000
Message : Merge pull request #44 from HealthBioscienceIDEAS/histogram_updates

Update histograms for latest napari-matplotlib version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants