-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update histograms for latest napari-matplotlib version #44
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/HealthBioscienceIDEAS/microscopy-novice/compare/md-outputs..md-outputs-PR-44 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-01-26 10:06:54 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks so much better! Note a minor suggestion of red green blue in the legend of one histogram, but if that is a real pain to do, go ahead and merge as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How easy would it be to change the legend to red green blue instead of rgb?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just had a quick look, and there doesn't seem to be an easy way to change the legend via napari-matplotlib. Seems this would require further changes directly to the napari-matplotlib plugin - so I'll go ahead and merge for now. If adjusting the legend is something we need in future, we can always open another issue on the napari-matplotlib repo.
Auto-generated via {sandpaper} Source : 3eae9cf Branch : main Author : Kimberly Meechan <[email protected]> Time : 2024-01-31 09:33:26 +0000 Message : Merge pull request #44 from HealthBioscienceIDEAS/histogram_updates Update histograms for latest napari-matplotlib version
Auto-generated via {sandpaper} Source : 7ce73de Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-01-31 09:34:46 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 3eae9cf Branch : main Author : Kimberly Meechan <[email protected]> Time : 2024-01-31 09:33:26 +0000 Message : Merge pull request #44 from HealthBioscienceIDEAS/histogram_updates Update histograms for latest napari-matplotlib version
Let's go ahead with it as now, but maybe we should open up an issue with napari-matplotlib. It doesn't need to be a blocker though. |
Auto-generated via {sandpaper} Source : 3eae9cf Branch : main Author : Kimberly Meechan <[email protected]> Time : 2024-01-31 09:33:26 +0000 Message : Merge pull request #44 from HealthBioscienceIDEAS/histogram_updates Update histograms for latest napari-matplotlib version
Auto-generated via {sandpaper} Source : 6c4f9a1 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-02-06 00:14:58 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 3eae9cf Branch : main Author : Kimberly Meechan <[email protected]> Time : 2024-01-31 09:33:26 +0000 Message : Merge pull request #44 from HealthBioscienceIDEAS/histogram_updates Update histograms for latest napari-matplotlib version
For #40
This PR updates all histogram images + text to match the newest version of napari-matplotlib. In the newest version: