Switch to SQL and providing more support for queries #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some bad code in here, but SQL is nice
…sql_solvers # Conflicts: # uv.lock
AndyRae
reviewed
Feb 5, 2025
| full_query_all_groups = select(func.count()).where(*all_groups_queries) | ||
|
|
||
| # here for debug, prints the SQL statement created | ||
| print(str(full_query_all_groups.compile( |
There was a problem hiding this comment.
logger.debug() instead of print()
AndyRae
reviewed
Feb 5, 2025
AndyRae
reviewed
Feb 6, 2025
# Conflicts: # src/hutch_bunny/core/settings.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Contents
As part of the refactor of the query solvers, we have changed the code from data frames to SQL.
This is a major change to how the queries are created and provides full support for the RQUEST API specification.
♻️ Refactor - removal of old data frame code
✨ Feature - new search functionality
🦋 Bug Fix - prevents a bug from causing issues
⚡️ Optimization - more resilient query creation to cope with OMOP vocab changes.
Description
Major change to query_solvers that has switched out all the previous query creation code and replaced with a gradual creation of the required SQL for rules and between groups. The consequence is a single SQL is created that performs the full query for all groups and rules.
Additional support for missing functionality has been added for certain types of queries not previously supported.
Related Issues or other material
Related Issue Bunny - Secondary modifiers not filtering results #6
Related Issue Bunny Availability Query with numeric criteria fails to process #13
Related Issue Refactor query solvers #47
Related Issue Modifiers not supported in Bunny #69
Related Issue Switch from dataframes to SQL #70
I've completed all actions and tasks detailed in the PR Template