Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code Distribution SQL query #63

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Refactor code Distribution SQL query #63

merged 6 commits into from
Jan 28, 2025
+145 −38

Conversation

vpnu
Copy link
Contributor

@vpnu vpnu commented Jan 28, 2025

Pull Request Contents
♻️ Refactor
⚡️ Optimization

Description

  • Adds join to concept table to get OMOP description in one query instead of two separate ones
  • Adds code distribution test, and fixes typos in demo.distribution tests

Related Issues or other material

  • This PR relates to one or more issues, detailed below

✅ Added/updated tests?

  • This PR contains relevant tests
    • Or doesn't need to per the below explanation

alt_text

  • I've completed all actions and tasks detailed in the PR Template

@vpnu vpnu merged commit d9df702 into main Jan 28, 2025
5 checks passed
@vpnu vpnu deleted the distr_gen_refactor branch January 28, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beforan beforan beforan approved these changes

@AndyRae AndyRae AndyRae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bunny Distribution Queries - OMOP Description efficiency
3 participants
@vpnu @AndyRae @beforan