Code cleaning up and renaming #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AndyRae
approved these changes
Jan 15, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Contents
Description
This PR deleted unused app, code and API endpoints which are deprecated by Carrot 3.0. This also update naming of some variables which had "old" names.
Regarding Docker compose improvement, some renaming works also took place. Also,
apiservice now depends oncompletedstatus ofomop-liteservice (to prevent the race condition related to OMOP tables creation and seeding fixtures) as well asfrontendnow depends onapi.Related Issues or other material
Screenshots, example outputs/behaviour etc.
✅ Added/updated tests?
Tested on local.
Tested on PR workflow