feat: handling REORG_STARTED event plus tests #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
changed the title
andreabadesso
force-pushed
the
feat/reorg-alert
branch
from
1c4f0d6 to
413da99
Compare
andreabadesso
force-pushed
the
feat/reorg-alert
branch
from
413da99 to
80a57f1
Compare
luislhl
reviewed
Jan 27, 2025
packages/daemon/src/config.ts
Outdated
Comment on lines
92
to
93
| export const REORG_SIZE_MAJOR = parseInt(process.env.REORG_SIZE_MAJOR ?? '10', 10); | ||
| export const REORG_SIZE_CRITICAL = parseInt(process.env.REORG_SIZE_CRITICAL ?? '10', 10); |
There was a problem hiding this comment.
The Major and Critical will have the same size by default?
There was a problem hiding this comment.
Refactored MAJOR reorg default to 5, thanks!
luislhl
previously approved these changes
Jan 27, 2025
glevco
previously approved these changes
Jan 27, 2025
luislhl
approved these changes
Jan 30, 2025
glevco
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During the wallet-service refactor, we lost the reorg size alert, this PR should add it back
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged