docs: pull request templates for new release process #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r4mmer
commented
Nov 3, 2023
| @@ -0,0 +1,8 @@ | |||
|
|
|||
| [//]: # (This should be discussed in the daily meeting) | |||
There was a problem hiding this comment.
This is just a simple hack to add some comments to the PR creator but without including them on the rendered PR.
For instance, this shows that the comment and surrounding blank lines will be ignored.
|
To better understand the new PR flow i'll add some screenshots of the expected behavior. The default PR template will show as: The user will then click for preview and it will show this: We can then use the links to select the desired PR template. |
r4mmer
force-pushed
the
docs/pull_request_templates
branch
from
bcc27ad to
eebe9f9
Compare
luislhl
reviewed
Nov 28, 2023
| @@ -0,0 +1,8 @@ | |||
|
|
|||
| [//]: # (This should be discussed in the daily meeting) | |||
| [//]: # (Remember to bump the version to the release version after this is merged) | |||
There was a problem hiding this comment.
"after" or "before"? I guess this depends on the release guide being built, but I thought it would be before.
luislhl
approved these changes
Nov 28, 2023
r4mmer
requested review from
alexruzenhack
and removed request for
pedroferreira1
alexruzenhack
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Description
We are using the features described in the github docs to create a PR template chooser and allow multiple PR templates on the github web ui.
These templates can also be used by name with the github cli or api (in a future integration) if needed.
Security Checklist